Open
Conversation
This commits add vagrant support for ircb, this is used to make development of ircb easy Signed-off-by: Farhaan Bukhsh(fhackdroid) <farhaan.bukhsh@gmail.com>
This commit adds Vagrantfile and ansible to add provision to Vagrant image Signed-off-by: Farhaan Bukhsh(fhackdroid) <farhaan.bukhsh@gmail.com>
farhaanbukhsh
force-pushed
the
vagran-file
branch
from
139cd3f to
315abee
Compare
Signed-off-by: Farhaan Bukhsh(fhackdroid) <farhaan.bukhsh@gmail.com>
Vagrantfile
Outdated
| ansible.playbook = "ansible/vagrant-playbook.yml" | ||
| end | ||
| config.vm.provision "shell", inline: "cd /home/vagrant/devel && sudo python3 setup.py develop" | ||
| config.vm.provision "shell", inline: "sudo systemctl start redis.service" |
Contributor
There was a problem hiding this comment.
we can migrate this to role?!
Contributor
Author
There was a problem hiding this comment.
for redis I have a handler written
Signed-off-by: Farhaan Bukhsh(fhackdroid) <farhaan.bukhsh@gmail.com>
Signed-off-by: Farhaan Bukhsh(fhackdroid) <farhaan.bukhsh@gmail.com>
rtnpro
requested changes
Apr 1, 2017
| RUN dnf install -y python2-devel python-setuptools python-nose py-bcrypt python-alembic \ | ||
| python-pip python3-devel openssl-devel redis python3-pip | ||
|
|
||
| RUN pip3.4 install Flask==0.10.1 Flask-SQLAlchemy==2.0 Flask-User==0.6.11 \ |
Member
There was a problem hiding this comment.
Why not install from requirements.txt?
|
|
||
| EXPOSE 9000 10000 6379 | ||
|
|
||
| CMD ["redis-service"] |
Member
There was a problem hiding this comment.
Why start redis-service? Won't it be better to have ircb as entrypoint and ["run", "allinone"] as default command? This will open up possible usecases like:
docker run ircb run stores
docker run ircb run bouncer
and so on ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commits add vagrant support for ircb, this is used to make
development of ircb easy
Signed-off-by: Farhaan Bukhsh(fhackdroid) farhaan.bukhsh@gmail.com